refactor(pg/catalog): use explicit pretty bool for view-def getters#311
Open
h3n4l wants to merge 1 commit into
Open
refactor(pg/catalog): use explicit pretty bool for view-def getters#311h3n4l wants to merge 1 commit into
h3n4l wants to merge 1 commit into
Conversation
GetViewDefinition / GetMatViewDefinition took `pretty ...bool` solely to make the flag optional (Go has no default arguments). But every caller relied on the default and none ever passed a value, and the variadic silently accepts more than one bool with no compile-time arity check. Switch both to an explicit `pretty bool` and update all call sites to pass `false`. No behavior change; the signature is now precise. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
h3n4l
force-pushed
the
claude/compassionate-lamport-33384b
branch
from
8b2a026 to
34687b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Catalog.GetViewDefinitionandCatalog.GetMatViewDefinitiontookpretty ...bool. The variadic existed only to make the flag optional (Go has no default arguments) — the body just readpretty[0]and defaulted tofalse.In practice every one of the ~10 call sites omitted the argument and relied on that default; none ever requested pretty output. The variadic also weakens the contract:
GetViewDefinition(s, n, true, false)compiles and silently ignores the extra bool, with no compile-time arity check.This switches both methods to an explicit
pretty booland updates all callers to passfalse.Why
pretty=falsewas already the universal default.Changes
pg/catalog/ruleutils.go—pretty ...bool→pretty boolon both getters; drop thelen(pretty) > 0unwrap.false:migration_view.go(5),diff_view.go(2),migration.go(1),phase4_analyze_test.go(1),phase5_types_test.go(1).Verification
go build,go vet, andgo test ./pg/catalog/...all pass.🤖 Generated with Claude Code